Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22323 Fixed broken Thrift generation #196

Merged
merged 1 commit into from
Apr 29, 2019
Merged

HBASE-22323 Fixed broken Thrift generation #196

merged 1 commit into from
Apr 29, 2019

Conversation

HorizonNet
Copy link
Contributor

No description provided.

@HorizonNet HorizonNet added the bug label Apr 28, 2019
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 18 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 269 master passed
+1 compile 31 master passed
+1 checkstyle 33 master passed
+1 shadedjars 271 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 79 master passed
+1 javadoc 29 master passed
_ Patch Compile Tests _
+1 mvninstall 253 the patch passed
+1 compile 31 the patch passed
+1 javac 31 the patch passed
-1 checkstyle 33 hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 274 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 554 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 101 the patch passed
+1 javadoc 35 the patch passed
_ Other Tests _
+1 unit 213 hbase-thrift in the patch passed.
+1 asflicense 10 The patch does not generate ASF License warnings.
2317
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/1/artifact/out/Dockerfile
GITHUB PR #196
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d333e1cc4f79 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 4477dd5
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/1/artifact/out/diff-checkstyle-hbase-thrift.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/1/testReport/
Max. process+thread count 2029 (vs. ulimit of 10000)
modules C: hbase-thrift U: hbase-thrift
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 23 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 250 master passed
+1 compile 31 master passed
+1 checkstyle 33 master passed
+1 shadedjars 259 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 78 master passed
+1 javadoc 30 master passed
_ Patch Compile Tests _
+1 mvninstall 238 the patch passed
+1 compile 32 the patch passed
+1 javac 32 the patch passed
+1 checkstyle 33 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 256 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 502 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 92 the patch passed
+1 javadoc 31 the patch passed
_ Other Tests _
+1 unit 206 hbase-thrift in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2176
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/2/artifact/out/Dockerfile
GITHUB PR #196
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 645702b6315b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 5b07ee9
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/2/testReport/
Max. process+thread count 1971 (vs. ulimit of 10000)
modules C: hbase-thrift U: hbase-thrift
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-196/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet HorizonNet merged commit 882bbdb into apache:master Apr 29, 2019
@HorizonNet HorizonNet deleted the HBASE-22323 branch April 29, 2019 17:45
This was referenced Apr 14, 2024
Merged
Merged
Merged
Open
Open
Draft
Merged
Merged
Open
Merged
Merged
Merged
This was referenced Apr 21, 2024
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 29, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HorizonNet @Apache-HBase @Apache9